search

distributed-system-analysis / pbench

A benchmarking and performance analysis framework
http://distributed-system-analysis.github.io/pbench/
GNU General Public License v3.0
182 stars 109 forks source link

Clean up #3586

Closed dbutenhof closed 6 months ago

dbutenhof commented 6 months ago

This combines a few issues: first, I've wanted to filter based on the unpacked tarball size, but some tarballs are beyond the range of the SQL INTEGER type and cause SQL cast errors -- change the interpretation of the int filter and sort type to BigInteger. Also cleans up the logging around retried Sync transaction errors, only logging warnings when it can't determine that the error is a PostgreSQL serialization error. (I hope: this is hard to provoke in casual testing.) Finally, clean up the logging of cached unpacked size by avoiding two separate logs (without dataset name) on unpack, and adding a log of the final unpacked size when we compute it.

dbutenhof commented 6 months ago

Interesting ... presumably due to the new branch protection rules, main seems to be running only the Jenkins CI ...

webbnh commented 6 months ago

Interesting ... presumably due to the new branch protection rules, main seems to be running only the Jenkins CI ...

I'm not sure what you mean? (Under "checks", I see four entries -- Jenkins and three CodeQL thingies -- what else do you expect it to do?)

FWIW, main has its own branch protection rule, which should leave it unaffected by the other changes that we made to the rules....

dbutenhof commented 6 months ago

Interesting ... presumably due to the new branch protection rules, main seems to be running only the Jenkins CI ...

I'm not sure what you mean? (Under "checks", I see four entries -- Jenkins and three CodeQL thingies -- what else do you expect it to do?)

FWIW, main has its own branch protection rule, which should leave it unaffected by the other changes that we made to the rules....

Fascinating. That might be even weirder ... normally they all start around the same time, but only the Jenkins run appeared for quite a while. Maybe GitHub was just too backed up to show them? Never seen that before.