search

distributed-system-analysis / pbench

A benchmarking and performance analysis framework
http://distributed-system-analysis.github.io/pbench/
GNU General Public License v3.0
188 stars 108 forks source link

Fix deadlock and DELETE/UPDATE unindexed datasets #3620

Closed dbutenhof closed 6 months ago

dbutenhof commented 6 months ago

PBENCH-1328

A bug revealed another bug:

  1. POST/DELETE /datasets/{id} fails when the dataset isn't indexed; with the ability to disable server indexing entirely and to remove dataset indexed data, this is undesirable. As long as the dataset doesn't have a WORKING ops status, we should be able to update or delete.
  2. When the operation fails, the status is already set to WORKING, and this was not corrected on exit, leaving the dataset locked perpetually.

Fixed in two phases: first to correct the handling of errors so that we'll always unlock on failure; second to allow deletion of unindexed datasets. (For PR review, these phases are available in separate commits.)

dbutenhof commented 6 months ago

I was hoping to do some testing on a runlocal but for some reason I can't quite determine, the Keycloak container is working as expected, and the setup times out. If the CI runs, that'll be a useful diagnostic.

(And I probably should have posted as a Draft, because I realize that my second commit wiped out explicit testing of the WORKING state fix, which will now require some mocking to set up; but I'm also not sure I want to be spending more time on this. We'll see if I get bored over the weekend.)

dbutenhof commented 6 months ago

Ah: so I think I found our problem:

$ openssl x509 -enddate -noout -in server/pbenchinacan/etc/pki/tls/certs/pbench_CA.crt 
notAfter=Apr 25 21:37:54 2024 GMT

@webbnh Do you remember exactly what you did originally to generate the CA? (It should probably be recorded in a README.md in the pbenchinacan directory.)

Nevermind: I figured it out. I'm going to post a new commit with a new CA, but I'm also going to need to fix some stuff so I'm changing to draft.