search

distributev / the-app

The App
MIT License
0 stars 2 forks source link

show-user-friendly-invalid-login-message-and-seed-with-admin-user #115

Open distributev opened 8 years ago

distributev commented 8 years ago

This is happening in gulp serve:dist - please seed the databes with admin@theapp.com and admin password and make the invalid login message user friendly. Theapp is using bootrap so please check the bootstrap style which makes most sense to show for this invalid login.

i011 - invalid-login-message-and-seed-with-admin-user

distributev commented 8 years ago

Additional Information. I just noticed this EmptyResponse comes only when the email user does not exist at all. If the user exists but the password is wrong it comes a more user friendly error like "Incorrect Password" - even that does not have the correct style / collor (it's black) and it should not say "Incorrect Password" - Just do how Google is doing - show the same message which is user friendly enough but does not give the user too much details what exactly is wrong (otherwise people which have bad intentions could infere that password is not correct but the user exists ==> use this information and try to break)

Bottom line - for all situations where the combination user / password are not correct show the correct error style and show the same

The email and password you entered don't match.

message

distributev commented 8 years ago

And I know it was out of the scope of mail-merge and I appreciate If you can take a look to this.

luismanuel001 commented 8 years ago

Should the account seed for production be admin@example.com (like it currently is for dev), or should I change the whole seed behavior for production to not include the test@example.com and admon@example.com and include admin@theapp.com instead?

distributev commented 8 years ago

Do the same like it's currently for dev. It's good enough.