search

distributev / the-app

The App
MIT License
0 stars 2 forks source link

Datatables added again to bower.json? #95

Open distributev opened 8 years ago

distributev commented 8 years ago

Please see below. Datatables.net was already used into the-app to display the list of jobs (through angular-datatables).

So why was that required to add it again in bower.json all these datatables deps?

008 - datatables-again

luismanuel001 commented 8 years ago

Same as other dependency issue, I'm not sure about this, this just came straight from merging the ng-mail-merge-directive code into the theapp. I assumed the developer responsible for the ng-mail-merge-directive had already optimized and cleaned up unused dependencies, because otherwise I would need to spend a lot of time in just going over that code to determine what dependencies are used or not.

distributev commented 8 years ago

"otherwise I would need to spend a lot of time in just going over that code to determine what dependencies are used or not."

The developer worked on a very incipient code base. He started from a "scratch" angular js / node.js app (not even angular fullstack) where kue jobs (datatables) was not available at that time.

Meanwhile on the-app we already have datatables.net (added when kue jobs list was implemented) ==> we need to see if the 4 datatables.net extra deps does still make sense here (I suspect at least some of them to be redundant)

distributev commented 8 years ago

For now just give a fast "heuristic" look over the deps I have listed in my issues and try to answer with your fist "huntch" after you quickly trace what is required in code - don't spent lots of time for in-depth tracing now - Once we keep an eye on these we'll see better when something can be removed from bower.json - this is the situation - the developer did mail-merge from a new code-base.