district0x / name-bazaar

A peer-to-peer marketplace for the exchange of names registered via the Ethereum Name Service
Eclipse Public License 1.0
85 stars 23 forks source link

Make OfferingRegistry a proxy contract #200

Closed ladislavdubravsky closed 3 years ago

ladislavdubravsky commented 3 years ago

Summary

resolves #188

Review notes

Storage layout conflicts are a concern when using patterns with delegatecalls (https://mixbytes.io/blog/collisions-solidity-storage-layouts). Our MutableForwarder is simple enough to keep track of this and its simplicity is an advantage, but it could also be considered to use some well established Proxy implementation that would hide the storage concerns from our code.