search

distriqt / ANE-AndroidSupport

Android Support Library Native Extension
https://airnativeextensions.com
22 stars 4 forks source link

Java11 Requires Kotlin Update #14

Closed urthling closed 2 years ago

urthling commented 2 years ago

Opening a ticket in anticipation of kotlin stdlib compatibility with Java 11

marchbold commented 2 years ago

We are looking into this one.

marchbold commented 2 years ago

Can you elaborate on the error you are seeing? We aren't seeing any errors related to this currently only some warnings that seem safe to ignore.

urthling commented 2 years ago

I elaborated here: https://github.com/distriqt/ANE-Dialog/issues/281#

It will build with the Legacy flag but Dialogs won't work -- note what Andrew says about this and why: https://github.com/airsdk/Adobe-Runtime-Support/issues/1412#issuecomment-985260683

These are not warnings -- a regular build will fail because of this. You're trying with and without the legacy flag?

marchbold commented 2 years ago

Yes okay, but there is no error in that issue related to kotlin, just a warning which is safe to ignore.

The issue with the dialogs you are seeing is most likely another issue with the java packaging, see:

urthling commented 2 years ago

@marchbold this is not a warning:

Explanation for issues of type "Instantiatable":
Activities, services, broadcast receivers etc. registered in the manifest
file (or for custom views, in a layout file) must be "instantiatable" by
the system, which means that the class must be public, it must have an
empty public constructor, and if it's an inner class, it must be a static
inner class.

1 errors, 0 warnings
Lint found fatal errors while assembling a release target.

So, I guess this is the issue.. Hopefully Andrew will be able to get a new version of adt to resolve this..

marchbold commented 2 years ago

Yeah, okay, that's nothing to do with kotlin.