search

disusered / cordova-open

Open audio, video, images and more with applications installed on the user's device
MIT License
54 stars 55 forks source link

Plugin incompatible with cordova-plugin-camera #64

Open adrianjarc opened 5 years ago

adrianjarc commented 5 years ago

When using cordova-open and cordova-plugin-camera plugins together in an application, cordova-plugin-camera stops functioning.

More is explained here

disusered commented 5 years ago

Thanks for the in depth explanation on the other issue. I do not have a timeline to when I can look at this, so any help is appreciated. I do not recall adding paths in my plugin so I am assuming it's due to changes in Cordova. There must be a way to merge such properties.

adrianjarc commented 5 years ago

The commit that adds paths is: 6dd1407ae7b95d26c8b9bd80e239e6fc1f2b3077

I have solved this issue on my repository on develop branch, but I am not sure if plug-in works as standalone and all use cases (works for my use case), since I didn't have time to test it. I can make a pull request and you can test if plug-in works as intended.

disusered commented 5 years ago

Hi @TheDeathStreaker thank you for the contribution. Your commit and recent PRs have proven interest in the project continues and I hope to make amends and be a better steward.

I've been mulling over re-implementing CI, I will give it priority this weekend. Having the current contributions will be valuable in testing real-life use cases.

My biggest pain point will be integration testing, or anything that involves spinning up a simulator. If you or anyone who reads this has any advice or pointers on getting started with https://github.com/apache/cordova-paramedic or what CI provider has the best open source tooling with iOS/Android support, I would very much appreciate it.