search

ditashi / boblight

Automatically exported from code.google.com/p/boblight
GNU General Public License v3.0
0 stars 0 forks source link

width and height swapped in CLight::SetScanRange #44

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Code found in boblight_client.cpp Line 249.

    m_hscanscaled[0] = Round32(m_hscan[0] / 100.0 * ((float)height - 1));
    m_hscanscaled[1] = Round32(m_hscan[1] / 100.0 * ((float)height - 1));
    m_vscanscaled[0] = Round32(m_vscan[0] / 100.0 * ((float)width  - 1));
    m_vscanscaled[1] = Round32(m_vscan[1] / 100.0 * ((float)width  - 1));

VScan should be width, and vice versa.

Original issue reported on code.google.com by carstenp...@googlemail.com on 26 Jul 2012 at 4:23

GoogleCodeExporter commented 9 years ago 
Hm, and nobody noticed :)

Original comment by bob.loo...@gmail.com on 30 Jul 2012 at 7:54

GoogleCodeExporter commented 9 years ago 
Its not a issue if you always call with width==height, eg. 
SetScanRange(size,size)

Original comment by carstenp...@googlemail.com on 30 Jul 2012 at 8:04

GoogleCodeExporter commented 9 years ago 
Fixed in r445.

Original comment by bob.loo...@gmail.com on 30 Jul 2012 at 9:12

GoogleCodeExporter commented 9 years ago

Original comment by bob.loo...@gmail.com on 30 Jul 2012 at 9:12