Allow enabling/disabling rules

sjmatta commented 9 years ago

Inspired by .eslintrc:

Allow a root .cflintrc (JSON) to define which rules are turned on/off
Use those rules to create an XML configuration to send to CFLint
May require modification to CFLint so the configuration file can be piped through input

jjames967 commented 9 years ago

This shouldn't be very difficult to implement, although I'm not familiar with how Atom's package management works or it's linter. However, I would be very interested in getting the functionality going.

sjmatta commented 9 years ago

This will actually be pretty straightforward- I just need to write a tool to convert from JSON to the XML that CFLint understands, and then use stdin to apply those rules. Alternatively, I can help change CFLint to understand the JSON configuration.

jjames967 commented 9 years ago

That is actually a good idea of adding JSON configuration. I personally hate looking at xml. It's confusing and hard to read (shame on us deciding xml for config). I think it would be best to add the possibility of JSON config first, then deprecating the xml config. The deprecation would depend on Ryan, but I'm sure he'd be okay with it if we identify a possible breaking version.

How long do you think it would take? I'd like to get a new release out within two weeks with the recent items added. If you think it may take longer than that to put in and test, I may add another branch for it.

Once again, kudos for this package. I love it!

ryaneberly commented 9 years ago

I have no problem with switching to Json. :)

On Thu, Oct 8, 2015 at 11:49 PM, jjames967 notifications@github.com wrote:

That is actually a good idea of adding JSON configuration. I personally hate looking at xml. It's confusing and hard to read (shame on us deciding xml for config). I think it would be best to add the possibility of JSON config first, then deprecating the xml config. The deprecation would depend on Ryan, but I'm sure he'd be okay with it if we identify a possible breaking version.

How long do you think it would take? I'd like to get a new release out within two weeks with the recent items added. If you think it may take longer than that to put in and test, I may add another branch for it.

Once again, kudos for this package. I love it!

— Reply to this email directly or view it on GitHub https://github.com/ditinc/linter-cflint/issues/6#issuecomment-146748456.

sjmatta commented 9 years ago

Not sure on an ETA but I will try to look into it soon. The specific reason I'm interested in JSON configuration is that I'm trying to match other linters like coffeelint and eslint which use JSON configuration.

ghedwards commented 9 years ago

Sorry I know you maybe working a solution that will take care of this, but what's the best way to configure the rules when using CFLint with CF/SublimeLinter currently?

sjmatta commented 9 years ago

@ghedwards: This is the repository for an Atom package - I'd still be happy to help you out but unfortunately I'm not familiar with the Sublime plugin. I'd recommend asking the question over at https://github.com/SublimeText/ColdFusion

sjmatta commented 8 years ago

In 0.7.0 I enabled disabling rules. I went with an .eslintrc style rule naming declaration to keep consistent with that style- however all it does is lowercase the rule IDs and change _ to -. The implementation is pretty rough and I'd like tighter integration with CFLint, but it works for now. :)

sjmatta commented 8 years ago

Still need to add enabling or escalating rules from warnings to errors, as well as some other features, so I'll leave this issue open.

ocssor commented 8 years ago

@sjmatta not sure if your last comment is referring to what I'm about to say but: should be an option to blanket ignore 'warnings' and only display 'errors'.

lramirez925 commented 7 years ago

An update for this. It looks like cflint has implemented a json based config file. i think for consistency across all the plugins for this any changes should be done in the core to include/exclude rules. Then simply the plugins need to manage how each editor interacts with the cli/jar

philcruz commented 7 years ago

CFLint supports .cflintrc now. But the plugin doesn't recognize it. What would it take for it to support that?

sjmatta commented 7 years ago

Need to update the version of CFLint used here (preferably grabbing it from Maven repo)
Need to ensure CFLint isn't pushing random stuff out to standard out that will confuse the parser(s) - if not, CFLint needs a patch
Remove .cflintrc support from the plugin so it uses CFLint's instead

If anyone has availability to work on this in a PR, that'd be awesome. If not, I may have a chance to get to it in the next few weeks.

ditinc / linter-cflint

Allow enabling/disabling rules #6