In Trace package, right now we are forced to use GCP exporter, which is fine for Dito use case. But, thinking that go-dito is an open source project, i don't think this package should be locked in with GCP.
This pull request aims to make possible to the user of the package specify which exporter he wants to use.
How to test
You can create a simple Go project that instantiates go-dito trace package, specifying another exporter or no.
There is none!
I kept the GCP exporter as default if no other exporter is provided. None system that uses this package should be impacted.
Disclaimer
Like we discussed in the meetings, everyone should feel free to discuss the idea or implementation of this pull request, and even don't approving it if the change is not relevant to the project!
Change overview
In
Trace
package, right now we are forced to use GCP exporter, which is fine for Dito use case. But, thinking that go-dito is an open source project, i don't think this package should be locked in with GCP.This pull request aims to make possible to the user of the package specify which exporter he wants to use.
How to test
You can create a simple Go project that instantiates go-dito trace package, specifying another exporter or no.
Example using Jaeger exporter
Example using the GCP default exporter
Deploy impacts
There is none! I kept the GCP exporter as default if no other exporter is provided. None system that uses this package should be impacted.
Disclaimer
Like we discussed in the meetings, everyone should feel free to discuss the idea or implementation of this pull request, and even don't approving it if the change is not relevant to the project!
Thanks!