search

ditojs / dito

Dito.js is a declarative and modern web framework with a focus on API driven development, based on Objection.js, Koa.js and Vue.js – Developed at Lineto by Jürg Lehni and made available by Lineto in 2018 under the MIT license
https://lineto.com
MIT License
82 stars 8 forks source link

isUrl fails for long tlds #52

Closed puckey closed 3 years ago

puckey commented 3 years ago

We noticed that the isUrl utility function was failing for tlds longer than 6 characters. Added two failing tests to the following PR to demonstrate: https://github.com/ditojs/dito/pull/51/commits/934e4af3f266e03742e165df3b2db21ba5ba9ff9

puckey commented 3 years ago

Fixed in this PR: https://github.com/ditojs/dito/pull/53