Inconsistent status code for login API endpoint

[sohzaz]

Describe the bug

The login API endpoint produces different codes depending on what validation error it experienced :

• 500 : "user not found"
• 404 : "email not found"
• 401 : "invalid login credentials"

To Reproduce

Steps to reproduce the behavior:

1) call /login with :

• invalid email
• valid email with invalid password

• [possibly a leto issue] valid credentials (email + password) with a restarted gandalf node

  2) observe response code

Expected behavior

Status code should be uniformly 403 (or 401) on login failure

Application (please complete the following information):

• leto fcf65e2dcc7bfac25703315140909582172f5005
• gandalf 07fbedc751cc6bee9dc41679914564591518e4c1

Desktop (please complete the following information):

• OS : Win10 21H2
• Browser : Chrome
• Version : 103.0.5060.53