search

ditto-codes / planter-svelte

MIT License
1 stars 0 forks source link

Base style `a` selector is overspecific #8

Open matthew-ia opened 1 year ago

matthew-ia commented 1 year ago

a:not(.unstyled) is too specific and can cause unintentional overriding behavior with <a> that are rendered by a component and have component-scoped styles.

E.g., the a:not(.unstyled) in base.scss rule will override a <Button>'s text color. This becomes apparent if you change the link color token to be a different color than the button's component-scoped color.

matthew-ia commented 1 year ago

Need to double check in a fresh project—it's possible I changed something in button.svelte that caused this. I feel like it should happen on the demo page if it's actually an issue, but I don't think that's the case.