search

ditto-lab / ditto

NFT Future protocol
MIT License
60 stars 3 forks source link

Allow `duplicate` to mint to any address? #57

Closed calvbore closed 1 year ago

calvbore commented 1 year ago

Should we allow duplicate to mint clones to arbitrarily defined addresses instead of only msg.sender?

0xbok commented 1 year ago

This can enable gasless minting, and will be a good UX for users. A negative I see is an address might not want a clone minted to them. Also if the NFT gets sold via ditto, that arbitrary address may become the owner. Might be undesirable.

We can circumvent this by requiring a signature from the address saying they permit a clone minted to them by msg.sender.

calvbore commented 1 year ago

Honestly, i think that solution is a bit over engineered. If someone has a clone minted to them that they don't want they can call dissolve() on it.

0xbok commented 1 year ago

It falls upon the receive to call and spend gas on dissolve(). I agree that it doesn't matter in most cases, and this is over-engineering things. I was thinking about spam attacks but that's true for all the NFTs today so it should be fine for Ditto as well.

As an aside, implementing signatures can be good UX (relayers), but given that our users are primarily going to be traders, relayers won't be as useful to them.

calvbore commented 1 year ago

yeah i agree with you. Another concern i have is the future of account abstraction, and enshrining ECDSA may be a hindrance in the future