separate svg, add deploy script - Githubissues

ditto-lab / ditto

NFT Future protocol

MIT License

60 stars 3 forks source link

separate svg, add deploy script #62

Closed 0xbok closed 1 year ago

0xbok commented 1 year ago

SVG is now a different library. Main contract static calls to get tokenURI.
constant variables are now internal.
onTokenReceived doesn't take underlying nft contract's address since msg.sender is already there. Since it's a private function and DittoMachine will freeze after deployment, I dont see the harm in making this change when it gives gas savings. Let me know if you disagree.
forge script to deploy contracts.

https://goerli.etherscan.io/address/0xB9850A07396A5C968c2BaA8dF70d2337085d3e1a#code https://goerli.etherscan.io/address/0xfec759faefa065bd05bf78c3b8406e32e26ac0be#code

This is the order of PRs to merge into main (each one is dependent on the previous PR): https://github.com/ditto-lab/ditto/pull/62 https://github.com/ditto-lab/ditto/pull/61 https://github.com/ditto-lab/ditto/pull/63 https://github.com/ditto-lab/ditto/pull/64 https://github.com/ditto-lab/ditto/pull/65

calvbore commented 1 year ago

this looks good to me, you can merge whenever you're ready @0xbok