ditto-lab / ditto

NFT Future protocol
MIT License
60 stars 3 forks source link

`getMinAmountForCloneTransfer` should take the same paramaters as `duplicate()`? #67

Closed 0xbok closed 1 year ago

0xbok commented 1 year ago

I’m imagining the user flow would be like they first call getMinAmountForCloneTransfer and then call duplicate. So it’s a better UX to have the same parameters for them?

calvbore commented 1 year ago

That's a good question. I think that getMinAmountForCloneTransfer is more likely to be called by a contract though, and if somebody already knows the paramaters for dullicate it's pretty easy to hash them together off chain

0xbok commented 1 year ago

makes sense.