search

ditto-lab / ditto

NFT Future protocol
MIT License
60 stars 3 forks source link

Any protoid, cloneid combo can be passed to dissolve #69

Closed 0xbok closed 1 year ago

0xbok commented 1 year ago

We dont check that the clone is related to the proto

calvbore commented 1 year ago

Ah yes, you're right. We could check that keccak256(abi,encodePacked(protoId, index)) is equal to the cloneId provided to dissolve().

0xbok commented 1 year ago

Or we can pass protoId and index? edit: oh I forgot we made this change for easy composability. Let's discuss offline on what would be best.