search

ditto-lab / ditto

NFT Future protocol
MIT License
60 stars 3 forks source link

fee-on-transfer tokens not supported #77

Open 0xbok opened 1 year ago

0xbok commented 1 year ago

@calvbore this is not as easy since we transfer tokens at the very end after all the state changes. Supporting fee-on-transfer token would need to move erc20 transfer at the beginning. I'm inclining towards not supporting these kind of tokens now.

calvbore commented 1 year ago

@0xbok I think I'm also leaning towards not supporting them for now. The other option is to move it to the front of the transaction and add a reentrency guard. But, i think we could consider that for a next iteration.

0xbok commented 1 year ago

so there are 2 ways now: either we just say that users are responsible for ensuring that they dont use fee-on-transfer tokens with ditto (and frontend can also assist here), or we revert in the contract.