search

ditto-lab / ditto

NFT Future protocol
MIT License
60 stars 3 forks source link

Subsidy is permanently locked if NFT is burned #80

Open 0xbok opened 1 year ago

0xbok commented 1 year ago

I dont think the contract will be able to handle this scenario. We can just document in ditto book.

calvbore commented 1 year ago

Are you referring to the clone or the underlying NFT?

0xbok commented 1 year ago

underlying nft. not a security issue, just want to highlight this in the docs that subsidy can be only be transferred out by nft owner so there is a potential for it to be locked if nft is burned.

calvbore commented 1 year ago

yeah, sounds good. It is also possible for trading to happen on clones where no underlying NFT exists in the first place, as well. So we should also document that it should not be assumed by default that an underlying NFT even exists for a clone.

0xbok commented 1 year ago

yeah, we can create a section for user awareness. a few things are left to the user like using genuin erc20 and nft tokens. Also the mev issues.