Minimum supported iOS version

divadretlaw / CustomAlert

🔔 Custom Alert for SwiftUI

MIT License

195 stars 18 forks source link

Closed ravilich86 closed 2 months ago

ravilich86 commented 2 months ago

The library currently has a dependency on WindowKit, which is causing compatibility issues with iOS versions prior to iOS 17.

Is iOS 17+ the intended minimum supported version for this library?

Thank you for your attention to this issue.

divadretlaw commented 2 months ago

Is iOS 17+ the intended minimum supported version for this library?

No, iOS 14 is still the intended minimum.

The assumeIsolated() method is only available from iOS 17 onwards

Technically MainActor.assumeIsolated(_:file:line:) has been back ported to iOS 13.

But that being said, I think that is only the case using Swift 5.10+ and not the currently specified minimum of 5.9.

Do you need Swift 5.9 support?

If yes, I will re-add a variant I dropped because I wrongly thought it was generally back ported, not realizing it was only for Swift 5.10.

If not I will probably just increase the minimum required Swift version to 5.10

ravilich86 commented 2 months ago

Thank you for your quick and detailed response! I really appreciate your attention to this issue.

Regarding your questions and points:

My current setup:
- I'm using macOS Big Sur
- My Xcode version is 15.2, which only supports Swift 5.9
- With this setup, I can still build applications for iOS 17
Swift version support: Given my current environment, support for Swift 5.9 would be incredibly helpful. While I'm planning to update my machine in the near future, having Swift 5.9 support would allow me to use your library immediately without any compatibility issues.

divadretlaw commented 2 months ago

Sounds perfectly reasonable, I updated CustomAlert (and its dependencies) and tagged version 3.8.0

Should now work with Xcode 15.0+, as advertised with support for Swift 5.9

If it still doesn't work, please let me know, also thank you for noticing and reporting this issue 😺