divan / expvarmon

TermUI based monitor for Go apps using expvars (/debug/vars). Quickest way to monitor your Go app(s).
MIT License
2.02k stars 101 forks source link

Unable to clone https://gopkg.in/gizak/termui.v1 during build #25

Closed borud closed 5 years ago

borud commented 7 years ago

Not sure if this is a transient error or a permanent error.

santagada commented 7 years ago

its a permanent error, termui moved to github https://github.com/gizak/termui

divan commented 7 years ago

@borud @santagada hey, thanks for opening an issue. TermUI has been always at github, gopkg.in is a service that "pin" versions.

I suppose that gopkg.in had some downtime, hence the error. Now it works for me, can you please check it again?

santagada commented 7 years ago

they say on their github that the recomended way to use termui now is go get the master branch:

" master mirrors v2 branch, to install:

go get -u github.com/gizak/termui It is recommanded to use locked deps by using glide: move to termui src directory then run glide up.

For the compatible reason, you can choose to install the legacy version of termui:

go get gopkg.in/gizak/termui.v1 "

santagada commented 7 years ago

it still doesn't work for me:

go get -u github.com/divan/expvarmon
# cd .; git clone https://gopkg.in/gizak/termui.v1 /Users/santagada/go/src/gopkg.in/gizak/termui.v1
Cloning into '/Users/santagada/go/src/gopkg.in/gizak/termui.v1'...
error: RPC failed; HTTP 301 curl 22 The requested URL returned error: 301
fatal: The remote end hung up unexpectedly
package gopkg.in/gizak/termui.v1: exit status 128
ysqi commented 5 years ago

me too.

go get github.com/divan/expvarmon
package gopkg.in/gizak/termui.v1: unrecognized import path "gopkg.in/gizak/termui.v1" (parse https://gopkg.in/gizak/termui.v1?go-get=1: no go-import meta tags ())
aprice commented 5 years ago

For some unknown reason, the developer (gizak) seems to have deleted all tags prior to 2.0, and expvarmon is pinned to v1 using gopkg.in. This appears to be permanently broken by the maintainer of that dependency. Expvarmon's imports will have to be updated to fix it, and possibly vendored to insulate it from others' mistakes.

divan commented 5 years ago

@aprice oh, wow, thanks for the heads up. I'll check this asap and will refactor code to use the latest termui (something I should have done a long time ago). Thanks again.

divan commented 5 years ago

I pushed changes to termui-master branch. Could you please double check it works properly? I'll merge it with master asap.

powo commented 5 years ago
[powo@zion expvarmon (termui-master)]
$ go get github.com/gizak/termui

[powo@zion expvarmon (termui-master)]
$ go build
# github.com/divan/expvarmon
./ui_multi.go:12:14: undefined: termui.Paragraph
./ui_multi.go:13:14: undefined: termui.Paragraph
./ui_multi.go:14:14: undefined: termui.List
./ui_multi.go:15:16: undefined: termui.List
./ui_multi.go:16:14: undefined: termui.Sparklines
./ui_multi.go:17:14: undefined: termui.Sparklines
divan commented 5 years ago

@powo go get -u github.com/gizak/termui perhaps? (without -u go get will not download an updated version to GOPATH). PS. I have branch with modules support, that should be the right way to do things, but let's do one thing at a time.

jimmysawczuk commented 5 years ago

I have this version of termui installed but I'm still getting those compilation errors:

commit a01016fd0db1e749d0dffea94598b51d68f0cf73 (HEAD -> master, origin/master, origin/HEAD)
Author: Caleb Bassi <calebjbassi@gmail.com>
Date:   Mon Jan 28 01:13:33 2019 -0800

    Update readme
$ go install ./...
# github.com/divan/expvarmon
./ui_multi.go:12:14: undefined: termui.Paragraph
./ui_multi.go:13:14: undefined: termui.Paragraph
./ui_multi.go:14:14: undefined: termui.List
./ui_multi.go:15:16: undefined: termui.List
./ui_multi.go:16:14: undefined: termui.Sparklines
./ui_multi.go:17:14: undefined: termui.Sparklines
divan commented 5 years ago

Okay, in between the messages in this thread, "The Great Rewrite" has happened in termui (again).

Going to fix that and add go.mod.

divan commented 5 years ago

I added go.mod and vendored correct versions because the new rewrite of termui will require pretty serious refactoring. :/

Please try now build the master.

powo commented 5 years ago

works :+1:

jimmysawczuk commented 5 years ago

Works for me too. 👍