fix (footer): remove absolute position from footer - Githubissues

divanov11 / Mumble

An open source social media platform and public forum for questions and discussions, built for developers.

https://www.mumble.dev/

Apache License 2.0

303 stars 207 forks source link

fix (footer): remove absolute position from footer #489

Closed ghost closed 1 year ago

ghost commented 1 year ago

Well detailed description of the change :

I worked on the footer styles to remove position: absolute from LoginOrSignUp.css.

Context of the change

1. Why is this change required ?

This fixes the whitespace issue due to content height when the layout switches to single column view at 1100px.

2. Does it solve a problem ? (please link the issue)

Yes, it addresses issue #488

Type of change

[x] Bug fix

Preview (Screenshots) :

Before:

After:

Checklist:

[x] I have read the CONTRIBUTING document.
[x] My code follows the STYLE_GUIDE of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] All new and existing tests passed.

Reviewers

@Mr-spShuvo @divanov11

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
mumble	✅ Ready (Inspect)	Visit Preview	Nov 6, 2022 at 8:40AM (UTC)