setup editor config, flake8 and isort

divanov11 / mumbleapi

Backend/API for the Mumble.dev, an open source social media application.

Apache License 2.0

199 stars 122 forks source link

setup editor config, flake8 and isort #89

Open itzomen opened 3 years ago

itzomen commented 3 years ago

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

Want to add a basic .editorconfig file
Next, we’ll add flake8 to enforce PEP8 rules
Finally, isort to have a standard way of sorting imports

Additional context

Well, the main aim is to maintain style consistency in the project as it grows.

abhivemp commented 3 years ago

Hey @itzomen Thanks for your suggestion! How do you want flake8 styling to work? Usually, it goes by every branch merge. Are you thinking of something else?

itzomen commented 3 years ago

Hey @itzomen Thanks for your suggestion! How do you want flake8 styling to work? Usually, it goes by every branch merge. Are you thinking of something else?

Well, wanna just setup the basic for code linting so the code base follows pep8 rules

M-krishna commented 3 years ago

Hey, if this is not started I can pick this up. Thanks!

abhivemp commented 3 years ago

@M-krishna it's already been implemented. We aren't pushing this patch yet because this is a post-MVP feature

M-krishna commented 3 years ago

@M-krishna it's already been implemented. We aren't pushing this patch yet because this is a post-MVP feature

Cool then!

abhivemp commented 3 years ago

@itzomen I am going to open your PR. Let's it is corporate this feature because it's the least we can do to clean up the codebase. Update your branch accordingly and tag me when you are done. I'll reciew and merge.