search

divanov11 / proshop_django

407 stars 430 forks source link

Reset productDetails before request #10

Open shjeong92 opened 3 years ago

shjeong92 commented 3 years ago

Hey Dennis I really enjoyed your Udemy course!

I found a minor bug which is about ProductScreen component.

To explain how to see the bug,

  1. At the first time you click product from the HomeScreen, \<Loader \/> works just fine in ProductScreen component, but from the second times, it doesn't work anymore.
  2. If you go back and choose other items, somehow doesn't work, and it also shows previous item infos for a short time(which bothers me).

This PR will fix the bug. cheers!

Sanghyuk from Korea.

mrcaption49 commented 3 years ago

Yes same thing happens with me

On Fri, 14 May 2021, 2:35 pm Sanghyuk Jeong, @.***> wrote:

Hey Dennis I really enjoyed your Udemy course!

I found a minor bug which is about ProductScreen component.

To explain how to see the bug,

  1. At the first time you click product from the HomeScreen, works just fine in ProductScreen component, but from the second times, it doesn't work anymore.
  2. If you go back and choose other items, somehow doesn't work, and it also shows previous item infos for a short time(which bothers me).

This PR will fix the bug. cheers!

Sanghyuk from Korea.

You can view, comment on, or merge this pull request online at:

https://github.com/divanov11/proshop_django/pull/10 Commit Summary

  • Reset productDetails before request

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/divanov11/proshop_django/pull/10, or unsubscribe https://github.com/notifications/unsubscribe-auth/APNBYSOZLIEVR7WJ325INH3TNTRWHANCNFSM444CCZXQ .

shjeong92 commented 3 years ago

@mrcaption49 These three changes fixed the bug :) hopefully it will work on yours too