divaprotocol / diva-monorepo

Diva Monorepo
https://diva.finance
4 stars 4 forks source link

[Bug] Create Offer: Minimum Taker Fill amount check #686

Closed Walodja1987 closed 1 year ago

Walodja1987 commented 1 year ago

Context

It seems that the check implemented for Minimum Taker Fill Amount in Create Offer currently checks agains the Collateral Amount rather than taker share. Adjust.

Here an example where it would throw if the amount is above 10 (collateral amount) but not if it's below collateral amount but above taker share:

image image

Walodja1987 commented 1 year ago

Done in #694