divaprotocol / diva-monorepo

Diva Monorepo
https://diva.finance
4 stars 4 forks source link

Unused `exchangeProxy` in `constants.ts` #780

Open Walodja1987 opened 1 year ago

Walodja1987 commented 1 year ago

Context

It seems that exchangeProxy stored inside constants.ts is not used and instead the address is read via getContractAddressesForChainOrThrow from the @0x/contract-addresses package. See SellMarket.js file for instance.

I noticed that because the current Goerli exchangeProxy address is incorrect (0xdef1c0ded9bec7f1a1670819833240f027b25eff instead of 0xf91bb752490473b8342a3e964e855b9f9a2a668e), but 0x fill operations are still working.

Confirm and clean up.

image

image