search

diveintomark / diveintohtml5

Dive Into HTML5 online book
https://diveintohtml5.info/
Other
777 stars 187 forks source link

Upgraded detect.html to Google Maps v3 as it had a broken v2 API key on d #1

Closed mammo closed 13 years ago

mammo commented 13 years ago

Upgraded detect.html to Google Maps v3 as it had a broken v2 API key on diveintohtml5.info and v3 doesn't require a key.

jonathantneal commented 13 years ago

Good call. I need to get linked up with these guys so I can share source with them and vice versa.

UPDATE: I've updated both http://diveinto.org/html5/detect.html and http://diveintohtml5.info/detect.html

mislav commented 13 years ago

Don't forget about geolocation.html

jonathantneal commented 13 years ago

Thank you, mislav, I believe it has been or is currently being patched. A lot of this had to do with Mark using a depreciated API. It certainly wasn't depreciated when he started using it, but the net evolves, and so much this project.

mammo commented 13 years ago

It has been patched in your repository, but not in this. As this request hasn't been pulled, I didn't bother to make another one here, but of course I could.

On 6 okt 2011, at 20:58, Jonathan reply@reply.github.com wrote:

Thank you, mislav, I believe it has been or is currently being patched. A lot of this had to do with Mark using a depreciated API. It certainly wasn't depreciated when he started using it, but the net evolves, and so much this project.

Reply to this email directly or view it on GitHub: https://github.com/diveintomark/diveintohtml5/pull/1#issuecomment-2313626

jonathantneal commented 13 years ago

Yea, and I have a question about that (if the owners of this are listening).

Is this going to be a preservation of the repository or a continuing of the repository? Both are fine, the former means everything stays the same and people have access to it the way it was. The later means you'll at least patch old APIs and fix broken links and from there potentially update the project with relevant language to the times and even new contributions.

mislav commented 13 years ago

I've tried contacting @diveintomark with a request to change his name to something else (to indicate that he/she's not the real Mark Pilgrim), but have gotten no reply.

kennethreitz commented 13 years ago

Sorry for the delay on this, guys.

I think that keeping the repository up-to-date with fixes is more than appropriate.

kennethreitz commented 13 years ago

Website has been brought up to date.