search

diveintomark / diveintohtml5

Dive Into HTML5 online book
https://diveintohtml5.info/
Other
777 stars 187 forks source link

Add Jonathan as a contributor #22

Closed jayphelps closed 12 years ago

jayphelps commented 12 years ago

Considering...it became his repo too when you guys merged.

kennethreitz commented 12 years ago

As I said, I'll be happy to add @jonathanneal back if he agrees to not revert the commit again until this us discussed more at #20. This is not a minor change.

jonathantneal commented 12 years ago

@kennethreitz, it's pretty clear what happened. I suspect that we misunderstood each other's actions. I thought you were reacting hasty to revert my change, as you probably felt similarly about mine, and I fought more than I should have for it. We really should have talked first. I've learned from this. I hope you have too. I'm not just saying that to make things appear even. I really believe it.

My stand is the same on the issue, but (I hope) neither of us were ever attempting a revert war to begin with, nor would we ever want to, and in the future I'm sure we'll have learned a lot from this experience.

@paulirish has closed #20. It seems the issue will never be resolved.

Am I still banned?

kennethreitz commented 12 years ago

Added back :)

kennethreitz commented 12 years ago

Sorry for the bluntness, by the way. I agree with everything you said and I'm pretty sure we're on the same page.

:sparkles: :cake: :sparkles: