search

diveintomark / diveintohtml5

Dive Into HTML5 online book
https://diveintohtml5.info/
Other
777 stars 187 forks source link

Incorrect external quote in charset meta #63

Closed jodydonetti closed 10 years ago

jodydonetti commented 11 years ago

Here http://diveintohtml5.info/semantics.html, while quoting the external explanation for the html5 short syntax, you quote:

The rationale for the attribute combination is that UAs already implement it, because people tend to leave things unquoted, like:

<META HTTP-EQUIV="Content-Type" CONTENT="text/html;" charset="ISO-8859-1">

and the piece of code incorrectly has quotes. They should be removed.

myakura commented 11 years ago

It is "correct"; the "quote" you mentioned is quoted from a message explaining why the charset attribute had already been understood by pre-HTML5 browsers.

jodydonetti commented 11 years ago

Yeah, I know: and in that message you linked it says "people tend to leave things unquoted, like" and then it gives an example, unquoted. That because it is presenting an example of "bad" syntax.

Quoting the entire block, but adding the quotes, doesn't make sense: the original message is giving an example of unquoted syntax, with an unquoted example, whereas here we are giving an example of unquoted syntax, but with an example that is quoted.

I hope to have explained myself well, if not please let me know.

I'll add 2 screenshots to better explain what I mean.

originalmessage-no-quotes

diveintohtml5-quotes-error

myakura commented 11 years ago

Oops. My bad. Sorry~ (Perhaps it went wrong when the source got canonicalized to wrap all attribute values in quotes.)

jodydonetti commented 11 years ago

No problem, thanks ;-) !

jonathantneal commented 10 years ago

@njy, good catch! @myakura, excellent deduction, and you are entirely correct. I will correct this at the first available opportunity.

jonathantneal commented 10 years ago

Corrected.