search

diveintomark / diveintohtml5

Dive Into HTML5 online book
https://diveintohtml5.info/
Other
777 stars 187 forks source link

Generic Headers using hgroup deprecated #69

Closed tchalvak closed 9 years ago

tchalvak commented 10 years ago

This page: http://diveintohtml5.info/semantics.html#header-element

gets into explaining the need to make headers generic, but it relies on the hgroup element to explain how that would work, which is now deprecated: http://www.w3.org/html/wg/drafts/html/master/common-idioms.html#sub-head

Now, the current recommendation is effectively to use: 

    <header><h1>main-title</h1><p>sub-heading</p></header>

Or some variation thereof, simple and sweet. http://www.w3.org/html/wg/drafts/html/master/common-idioms.html#sub-head

I could make a pull request with simplification & changes if that's the appropriate approach for this repository.

paulirish commented 10 years ago

Yup a PR would be excellent. Thanks @tchalvak

tchalvak commented 9 years ago

Err, PR exists https://github.com/diveintomark/diveintohtml5/pull/75 Let me know if anything isn't up to code. bu-dun-ptch

paulirish commented 9 years ago

closed by #75 thanks!