search

divergencetech / ethier

Golang and Solidity SDK to make Ethereum development ethier
MIT License
217 stars 23 forks source link

Remove ERC721APreApproval #49

Closed cxkoda closed 2 years ago

cxkoda commented 2 years ago

This removes the OpenSea proxy pre-approval from ERC721ACommon and the library in general.

syffs commented 2 years ago

@cxkoda any explanation why this was removed instead of updated ?

you can still pre-approve opensea, you just have to do it differently by pre-approving the conduit

ARR4N commented 2 years ago

Our experience with OS pre-approval generally wasn't positive. Collectors were confused when they saw it on sites like revoke.cash and became nervous about their being a hack/bug. Overall it caused more headaches than it solved.