divergencetech / ethier

Golang and Solidity SDK to make Ethereum development ethier
MIT License
217 stars 23 forks source link

Update PaymentSplitterDeployer with new factory addresses #89

Open Willyham opened 1 year ago

Willyham commented 1 year ago

I deployed a new PaymentSplitterFactory contract for mainnet and Goerli. These new deploys use the contracts from OZ 4.7.0, which have a new releasable function (amongst other changes).

Mainnet factory: https://etherscan.io/address/0x10af0996e2e289dc8f582e6510b0d251e061bfb5 Goerli factory: https://goerli.etherscan.io/address/0x1353463A30F7A9Eb50A645F4D3950d5d5E41F1F4

Willyham commented 1 year ago

Deployed a splitter via the factory on Goerli and confirmed that the releasable function now works:

➜  ethier git:(main) ✗ cast call 0xeD1Ad0e453220cDd3b3537efDEb7aAc382a620Ad "releasable(address)" 0x5B0c1a42F3836498D29d7Fae8268621C25701f27 --rpc-url $RPC_GOERLI | cast --to-dec
100000000000000000
ARR4N commented 1 year ago

Thanks for this. Confirming that I understand correctly: these are identical from an ethier perspective, but use the latest OZ deps?

Please can you update contracts/factories/README.md to match?

Willyham commented 1 year ago

That's right, there are no contract changes on either side - just a redeployment with the OZ libraries already installed in the current package.json (4.7.0).