divi255 / sphinxcontrib.asciinema

Easily embed asciinema videos into Sphinx documentation
MIT License
21 stars 12 forks source link

Fix `path` bugs #23

Closed ovidner closed 1 year ago

ovidner commented 1 year ago

This pull request fixes two bugs with the path option:

  1. Setting a path in the sphinxcontrib_asciinema_defaults does not have an effect, since the path option is only taken from the directive's own options.
  2. The path is passed on to the Asciinema class due to a space character in the searched key.
divi255 commented 1 year ago

thank you, merged