divi255 / sphinxcontrib.asciinema

Easily embed asciinema videos into Sphinx documentation
MIT License
21 stars 12 forks source link

Error in "asciinema" directive: unknown option: "title" #25

Closed zerocewl closed 8 months ago

zerocewl commented 10 months ago

With the update of sphinxcontrib.asciinema to v0.4.0 we get an issue

/builds/.../test.rst:80: ERROR: Error in "asciinema" directive:
unknown option: "title".
.. asciinema:: examples/test.cast
   :poster: npt:0:03
   :cols: 300
   :rows: 38
   :title: my test title

The change comes with update of asciinema from 2.6.1 to 3.6.3 PULLREQUEST: https://github.com/divi255/sphinxcontrib.asciinema/pull/24

and the remove of the title in this line

'title': directives.unchanged,

Is this intended?

divi255 commented 10 months ago

good day,

the asciinema player has been updated to 3.x. I'll take a look if they kept title parameter

zerocewl commented 10 months ago

hm looks like they removed it with v3?

https://github.com/asciinema/asciinema-player/releases/tag/v3.0.0

image

divi255 commented 10 months ago

seems so