All options are passed to asciinema-player as string

divi255 / sphinxcontrib.asciinema

Easily embed asciinema videos into Sphinx documentation

MIT License

21 stars 12 forks source link

All options are passed to asciinema-player as string #27

Closed Sarkutz closed 6 months ago

Sarkutz commented 6 months ago

Some asciinema-player options are non-string options. For example, the markers option is a list.

Currently, all options are passed to asciinema-player as string here. Hence, asciinema-player does not honour those options.

Is it possible to pass options to asciinema-player as per their type?

I faced this issue with markers option in sphinxcontrib.asciinema==0.4.1 using a local asciinema file.

Thank You for this great extension!

divi255 commented 6 months ago

markers are now passed as raw, with no quotes in 0.4.2. unfortunately it seems to way to specify markers for non self-hosted videos as "data" script tag properties accept strings only