search

divi255 / sphinxcontrib.asciinema

Easily embed asciinema videos into Sphinx documentation
MIT License
17 stars 11 forks source link

Crashes when building with singlehtml #9

Closed MatthewCroughan closed 3 years ago

MatthewCroughan commented 3 years ago

Using sphinx-build -b singlehtml crashes sphinxcontrib.asciinema with:

Exception occurred:
  File "/usr/local/lib/python3.8/site-packages/sphinxcontrib/asciinema/asciinema.py", line 38, in visit_html
    for n, v in node.options.items():
AttributeError: 'Asciinema' object has no attribute 'options'
divi255 commented 3 years ago

thanks for reporting. I hope to check both issues during the weekend

MatthewCroughan commented 3 years ago

Fantastic. I love this plugin. It makes documentation so much more fun and modern :smile:

divi255 commented 3 years ago

I've found the code didn't work properly with Sphinx 3.x+, it's strange how HTML parser worked. I've made full directive options refactoring, seems to work now (v0.2.0 published)