search

dividab / three-x3d-loader

Three.js Loader for the X3D format.
MIT License
15 stars 10 forks source link

Integrate X3D JSON format into loader. Does not depend on DOM. #5

Closed coderextreme closed 6 years ago

coderextreme commented 7 years ago

see issue

coderextreme commented 7 years ago

I tried to make it so it would still work as part of a project. I am not sure how well I succeeded.

jonaskello commented 7 years ago

This looks interesting :-). So the goal is to add support for x3d json encoding as described here?

coderextreme commented 7 years ago

Yes, that is the correct spot for the standardizing effort. There is a whole bunch of json files you can download from the X3D resources examples site.

Best, John

On Apr 12, 2017 4:15 PM, "Jonas Kello" notifications@github.com wrote:

This looks interesting :-). So the goal is to add support for x3d json encoding as described here http://www.web3d.org/wiki/index.php/X3D_JSON_Encoding?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jonaskello/three-x3d-loader/pull/5#issuecomment-293694338, or mute the thread https://github.com/notifications/unsubscribe-auth/AArE95ojwVSH6CgtBHstFt_d-t1HaZ_xks5rvTDMgaJpZM4M6ve7 .

coderextreme commented 7 years ago

Well, in order to run the new app.js, I require express. If it's still a dev dependency, or you have a better way of running a web server to test, let me know (instructions?).

On Apr 13, 2017 2:08 PM, "Jonas Kello" notifications@github.com wrote:

@jonaskello commented on this pull request.

In package.json https://github.com/jonaskello/three-x3d-loader/pull/5#discussion_r111451573 :

@@ -24,10 +24,13 @@ "webpack-dev-server": "^1.16.2" }, "dependencies": {

  • "express": "^4.15.2",

This should be a devDependency since express is not required to use the loader package.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jonaskello/three-x3d-loader/pull/5#pullrequestreview-32700510, or mute the thread https://github.com/notifications/unsubscribe-auth/AArE96pBsvDbwhTCSug2a_AsppoqegEOks5rvmSIgaJpZM4M6ve7 .