Update to support newer Three.js API and Blender-exported models

dividab / three-x3d-loader

Three.js Loader for the X3D format.

MIT License

15 stars 10 forks source link

Update to support newer Three.js API and Blender-exported models #6

Closed bcongdon closed 7 years ago

bcongdon commented 7 years ago

Thanks for making this module! Saved me a ton of headaches. 😁

Seems like it needs a bit of updates to support the newest THREE.js, and I noticed there were a couple bugs that prevented me from loading a Blender-exported X3D file.

I've tested these changes against a couple of my own models, but I'd welcome further scrutiny.

jonaskello commented 7 years ago

Thanks for the PR! Since we don't have any tests in this repo I'm a bit unsure about merging stuff but you changes seem small and well documented. I also ran the example and it works with your PR so I'll go ahead and merge this.

jonaskello commented 7 years ago

Published as 0.4.0.