dividab / tsconfig-paths-webpack-plugin

Load modules according to tsconfig paths in webpack.

MIT License

596 stars 51 forks source link

Pass through `ResolveTypes` from Webpack #97

Closed aaronadamsCA closed 1 year ago

aaronadamsCA commented 2 years ago

Resolves #88.

Unlike #93, this time I made the necessary internal changes.

Note there is now one type assertion due to a bad upstream type in tsconfig-paths. I filed https://github.com/dividab/tsconfig-paths/issues/217 to resolve, but for now the assertion should be fine, since it's only a type change - no functional changes.

codecov[bot] commented 2 years ago

Codecov Report

Merging #97 (d2d7b83) into master (a960c6b) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #97   +/-   ##
=======================================
  Coverage   56.20%   56.20%           
=======================================
  Files           4        4           
  Lines         153      153           
  Branches       32       32           
=======================================
  Hits           86       86           
  Misses         56       56           
  Partials       11       11

Impacted Files	Coverage Δ
src/options.ts	`85.71% <ø> (ø)`
src/plugin.ts	`46.07% <ø> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

jonaskello commented 2 years ago

Now that nested mainfields is supported in tsconfig-paths 4.1.0 you could try to upgrade and see if the types match better.

aaronadamsCA commented 2 years ago

Now that nested mainfields is supported in tsconfig-paths 4.1.0 you could try to upgrade and see if the types match better.

They do! I've updated this PR to remove the type assertion, since it's no longer necessary.

aaronadamsCA commented 2 years ago

@jonaskello, friendly bump here, as I believe this is still release-ready.