search

dividab / tsconfig-paths

Load node modules according to tsconfig paths, in run-time or via API.
MIT License
1.8k stars 100 forks source link

feat: add support for jsconfig.json #199

Closed F3n67u closed 2 years ago

F3n67u commented 2 years ago

close https://github.com/dividab/tsconfig-paths/issues/127

F3n67u commented 2 years ago

@jonaskello please help review this pr. thanks

F3n67u commented 2 years ago

@jonaskello please help review this pr. thanks

@jonaskello do you have time to review this feature?

jonaskello commented 2 years ago

@F3n67u I've asked @aleclarson to review this one

F3n67u commented 2 years ago

It would be more efficient to use readdirSync here, which is only one I/O call instead of two existsSync I/O calls.

@aleclarson thanks for your time. I already use readdirSync instead of existSync

F3n67u commented 2 years ago

@aleclarson could help take a look at other 2 pr I made?

F3n67u commented 2 years ago

@aleclarson I see you approved this pr. do you have enough permission to merge this pr?

jonaskello commented 2 years ago

@F3n67u Can you also update the README and CHANGELOG (under unreleased entry)? After that we should be good to merge.

F3n67u commented 2 years ago

@F3n67u Can you also update the README and CHANGELOG (under unreleased entry)? After that we should be good to merge.

all done! thanks for your time. @jonaskello

MichaelDeBoey commented 2 years ago

@aleclarson @dividab @jonaskello Any idea when this will be released?

jonaskello commented 2 years ago

We need to get #206 merged before next release because #205 is merged but needs to be changed by #206.

MichaelDeBoey commented 2 years ago

@jonaskello Would it be possible to temporarily revert #205 and cut a release already please?

This would help the work I'm doing on Remix Stacks (see https://github.com/remix-run/indie-stack/pull/63, https://github.com/remix-run/blues-stack/pull/57 & https://github.com/remix-run/grunge-stack/pull/50) a lot. That way we could use tsconfig-paths to load jsconfig too instead of trying out a custom solution.

jonaskello commented 2 years ago

@MichaelDeBoey This is released now in 4.0.0.

MichaelDeBoey commented 2 years ago

@jonaskello Are there any breaking changes? Looking at the CHANGELOG there aren't, but wanted to check to be sure.

jonaskello commented 2 years ago

The breaking changes are listed under the "changed" heading in the changelog.

aleclarson commented 2 years ago

This has a bug. We should be setting allowJs to true for jsconfig.json files.