Fix tests and lint

[nwalters512]

This fixes the failing test called out in https://github.com/dividab/tsconfig-paths/pull/174#discussion_r863079371. It also fixes a few more failing tests. The entire test suite now passes!

I also took the opportunity to remove some commented-out assertions and remove a few unnecessary bits that had // eslint-disable... comments.

I would strongly encourage the maintainers to set up CI to run on pull requests, not just on master, so that errors can be caught quickly and resolved before changes are merged!

[jonaskello]

@nwalters512 I was trying to get the tests running in CI for the PR. Could you try to merge master into this and push again?

[nwalters512]

@jonaskello I believe you're missing configuration from .github/workflows/ci.yml. You need on: [push, pull_request] instead of just on: [push]. The push event only handles pushes to this repo, not pushes to forks, which will be the workflow for external contributors. See https://github.com/scinos/yarn-deduplicate/blob/1d0906c46895ffc4a2f22ef762ed6e8474327944/.github/workflows/node.js.yml#L6 for an example.

[jonaskello]

@nwalters512 Ah, thanks, that may be it! It was running for the PR where I changed the workflow but I guess counts as just push. I updated master according to your example, could you try to merge it into this PR again?

[nwalters512]

@jonaskello looks like we're good now!

[codecov[bot]]

Codecov Report

Merging #211 (4a9240e) into master (98bbcdc) will decrease coverage by 2.49%. The diff coverage is 23.07%.

@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
- Coverage   70.26%   67.76%   -2.50%     
==========================================
  Files          10        9       -1     
  Lines         306      304       -2     
  Branches       92       93       +1     
==========================================
- Hits          215      206       -9     
- Misses         85       92       +7     
  Partials        6        6              

Impacted Files	Coverage Δ
src/register.ts	0.00% <0.00%> (ø)
src/config-loader.ts	83.33% <66.66%> (-3.04%)	:arrow_down:
src/mapping-entry.ts	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8e4452c...4a9240e. Read the comment docs.

[jonaskello]

@nwalters512 Perfect, thanks for the hint :-)