StandardLiterPerSecond is not calculated correctly

dividab / uom

Extensible unit of measure conversion with type safety for typescript

MIT License

18 stars 1 forks source link

Closed johankristiansson closed 5 years ago

johankristiansson commented 5 years ago

export const StandardLiterPerSecond = Unit.timesNumber(
  "StandardLiterPerSecond",
  3600 * 1000,
  StandardCubicMeterPerHour
`);

It should be 1000 / 3600

jonaskello commented 5 years ago

@johankristiansson Could you make a PR with a failing test and a fix?

johankristiansson commented 5 years ago

Actually it should be 3600 / 1000 instead of 1000 / 3600 (Monday morning math 🙂)

@jonaskello I've updated the PR and added tests.