search

dividab / uom

Extensible unit of measure conversion with type safety for typescript
MIT License
18 stars 1 forks source link

Corrected calculation for StandardLiterPerSecond #29

Closed johankristiansson closed 5 years ago

johankristiansson commented 5 years ago

This fixes #28

codecov[bot] commented 5 years ago

Codecov Report

Merging #29 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #29   +/-   ##
=======================================
  Coverage   86.49%   86.49%           
=======================================
  Files         149      149           
  Lines        1414     1414           
  Branches       86       86           
=======================================
  Hits         1223     1223           
  Misses        191      191
Impacted Files Coverage Δ
src/units/mass-flow.ts 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d4ad039...fd7952d. Read the comment docs.

jonaskello commented 5 years ago

Since #28 could happen, this means we have not test coverage for this case? Could you add that to the PR too?

jonaskello commented 5 years ago

@johankristiansson Ready to be merged?

johankristiansson commented 5 years ago

@jonaskello I would say so. The calculation has been fixed and tests have been added.

jonaskello commented 5 years ago

👍