dividab / uom

Extensible unit of measure conversion with type safety for typescript
MIT License
18 stars 1 forks source link

Added Units KiloJoulePerCubicMeter & BtuPerCubicFeet #36

Closed johankristiansson closed 4 years ago

codecov[bot] commented 4 years ago

Codecov Report

Merging #36 into master will decrease coverage by 88.7%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #36       +/-   ##
=========================================
- Coverage    88.7%     0%   -88.71%     
=========================================
  Files         148    148               
  Lines        1417   1590      +173     
  Branches       95     95               
=========================================
- Hits         1257      0     -1257     
- Misses        160   1590     +1430
Impacted Files Coverage Δ
src/units/heating-value.ts 0% <0%> (-100%) :arrow_down:
src/units-format/heating-value-format.ts 0% <0%> (-100%) :arrow_down:
src/format.ts 0% <0%> (-100%) :arrow_down:
src/units-format/electric-potential-format.ts 0% <0%> (-100%) :arrow_down:
src/unit-divide.ts 0% <0%> (-100%) :arrow_down:
src/units/angle.ts 0% <0%> (-100%) :arrow_down:
...units-format/delta-dew-point-temperature-format.ts 0% <0%> (-100%) :arrow_down:
src/units-format/thermal-transmittance-format.ts 0% <0%> (-100%) :arrow_down:
src/units/velocity.ts 0% <0%> (-100%) :arrow_down:
src/units-format/sound-power-level-format.ts 0% <0%> (-100%) :arrow_down:
... and 136 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6fa8ea1...62cf297. Read the comment docs.

jonaskello commented 4 years ago

Seems code coverage is not working. Currently we are using nyc. We should switch to using jest for tests because it has built-in support for code coverage.

jonaskello commented 4 years ago

@johankristiansson I have switched to jest in master, try rebasing this PR on master.

johankristiansson commented 4 years ago

@jonaskello Rebased on master

jonaskello commented 4 years ago

@johankristiansson You closed the PR... should it not be merged?