dividab / uom

Extensible unit of measure conversion with type safety for typescript
MIT License
18 stars 1 forks source link

Include typescript source in npm package #50

Closed jonaskello closed 4 years ago

jonaskello commented 4 years ago

This PR will include the typescript sources in src/ in the published npm package. We were already including *.map files but when eg. webpack tried to load them the referenced typescript files in src/ were not found so webpack emits a warning.

The choice is either to make a special production build without source maps and publish the *.js files without any sourcemap refrences, or include everything in the npm package. My reasoning here is that if we include everything it will be easier to get god stack traces and debug.

codecov[bot] commented 4 years ago

Codecov Report

Merging #50 into master will not change coverage by %. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #50   +/-   ##
=======================================
  Coverage   45.02%   45.02%           
=======================================
  Files           8        8           
  Lines         362      362           
  Branches       69       69           
=======================================
  Hits          163      163           
  Misses        181      181           
  Partials       18       18           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d601127...41b6958. Read the comment docs.

codecov[bot] commented 4 years ago

Codecov Report

Merging #50 into master will not change coverage by %. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #50   +/-   ##
=======================================
  Coverage   45.02%   45.02%           
=======================================
  Files           8        8           
  Lines         362      362           
  Branches       69       69           
=======================================
  Hits          163      163           
  Misses        181      181           
  Partials       18       18           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d601127...1d0c26b. Read the comment docs.