misused "dynamic_lib" and "static_lib" in meta.json of hdf5 package on Windows

dividiti / ck-caffe

Collective Knowledge workflow for Caffe to automate installation across diverse platforms and to collaboratively evaluate and optimize Caffe-based workloads across diverse hardware, software and data sets (compilers, libraries, tools, models, inputs):

http://cKnowledge.org

BSD 3-Clause "New" or "Revised" License

193 stars 40 forks source link

misused "dynamic_lib" and "static_lib" in meta.json of hdf5 package on Windows #66

Closed Chunosov closed 7 years ago

Chunosov commented 7 years ago

In local env of hdf5 package on Windows keys "dynamic_lib" and "static_lib" are misused

"dynamic_lib": "libhdf5.lib", 
...
"static_lib": "libhdf5.dll",

obviously *.lib is static, not dynamic, and vice versa.

Chunosov commented 7 years ago

It seems that 'lib' prefix here is redundant too. Files are called hdf5.lib and hdf5.dll

gfursin commented 7 years ago

Thanks, I fixed dynamic vs static lib. As for libhdf5 - actually both are generated on my system, so I automatically detect first libhdf5.lib and then hdf5.lib ...