divinorum-webb / tableau-api-lib

An API library that allows developers to call on the methods listed in Tableau's REST API documentation.
MIT License
96 stars 34 forks source link

Request Enabled settings for site is not working. #67

Closed rahulhacker closed 2 years ago

rahulhacker commented 2 years ago

curl --location --request PUT '/api/3.13/sites/' \ --header 'X-Tableau-Auth: xxxxxxxxxxxxxxxxxxxxxxxxxxx --header 'Content-Type: text/plain' \ --data-raw ' <site commentingEnabled="false" editingFlowsEnabled="false" requestAccessEnabled="false" dataAlertsEnabled="false" commentingMentionsEnabled="false"

 />

'

The above curl command working as expected, but while trying the same with tableau library not working for request enabled setting.

https://github.com/divinorum-webb/tableau-api-lib/blob/dd8d0486e149d4a919ec6336cea898755ce96433/src/tableau_api_lib/tableau_server_connection.py#L450

divinorum-webb commented 2 years ago

Hey @rahulhacker, thanks for raising this issue. There was a typo in an enum related to the requestAccessEnabled flag. This typo is fixed in the latest version of the library. Running pip install -U tableau-api-lib will do the trick.

In testing the fix, I am now getting a successful execution using the update_site() method as shown in this screenshot:

image