Aldryn-search dependency aldryn-common isn't compatible with newer django version

divio / aldryn-search

Haystack 2.0 search index for django CMS

Other

48 stars 77 forks source link

Aldryn-search dependency aldryn-common isn't compatible with newer django version #105

Open bhuiyanmobasshir94 opened 3 years ago

bhuiyanmobasshir94 commented 3 years ago

Django newer versions don't support QuerySetPaginator and I am getting errors while reindexing. I am explicitly getting this error. ImportError: cannot import name 'QuerySetPaginator' from 'django.core.paginator' When I commented out the above-mentioned class QuerySetPaginator from site-packages it works properly.

N.B: Aldryn-common is archived by authors, but why this popular library isn't updating their dependency.

filipweidemann commented 3 years ago

Bumping it. Currently running into the same issue as well.

Is there any effort by the maintainers? We can obviously help out, but considering this packages last commit is from 21st February 2020 I assume this is dead..?

filipweidemann commented 3 years ago

It is actually quite simple to fix this. aldryn_common is only used for its DiggPaginator, so technically we could open a PR with removed dependency and added DiggPaginator to aldryn_search's own codebase.

Gonna think about it..