czpython
commented
9 years ago Hello @fmarco,
I really like the concept but I don't like coupling a value as dynamic as a title to a setting in the settings file because titles can easily change.
Also you could easily hit an issue with duplicate titles as well as having non-ascii in settings file if you would like to target titles in other pages.
And last, supporting multiple languages would be very repetitive, a placeholder is not bound to title instance which means that it won't change from one title to the next so coupling a title to placeholder slots would result in one of these per title per page.
I see two potential solutions:
- Do as django-cms does and make the setting global, meaning that we create a list of excluded placeholder slots.
- Instead of page_title we can use reverse_id which is less likely to change and will immediately apply to all titles under a page.
My personal opinion is that best approach from code/best practice point of view is point 1 but from a flexibility point of view then point 2.
We could also implement both solutions in a cool setting in order to provide an easy way to target all placeholders or a placeholder under page x.
fmarco
…arch inside specific pages placeholders plugins
This PR add a simple specialization of get_search_data, to handle generic cases or specific cases related to one or more pages.
The idea is to set up this variable inside the project settings
PLACEHOLDERS_SEARCH_LIST = { 'page_title': [ 'placeholder_1', 'placeholder_2', etc. ], }
( or leave it empty to use the generic handling).