this commit fixes #75 - Githubissues

divio / aldryn-search

Haystack 2.0 search index for django CMS

Other

48 stars 77 forks source link

this commit fixes #75 #78

Closed carderm closed 5 years ago

carderm commented 6 years ago

Fix to work with Haystack >= 2.6 and Elasticsearch 2.x

w9co commented 6 years ago

832408a works for me. Were there further issues? It doesn't look like the build failures were related to this change.

maj0rr commented 6 years ago

Hey, how can we get this merged?

vinitkumar commented 5 years ago

Can we please get this merged?

marksweb commented 5 years ago

@czpython Can this fix get merged?

I'm just setting up a new project & opted for django-haystack 2.8.1 so I'm getting that backend grief that this fixes.

marksweb commented 5 years ago

@carderm @nlong1 @maj0rr @vinitkumar What are you guys doing about this?

Django needs to be at a minimum of 1.11 these days but support for that only comes in a version of django-haystack which doesn't work with aldryn-search.

What a nightmare.

maj0rr commented 5 years ago

Hey @marksweb, I referenced the fork with the merged fix from: https://github.com/jdgoettsch/aldryn-search

Requirements: git+https://github.com/jdgoettsch/aldryn-search@d9720a33ee6251d29e2ec86014af4eb998403f45#egg=aldryn-search

Hope this will help you!

marksweb commented 5 years ago

Thanks @maj0rr, I thought that'd be the best solution 👍

nicholasjuncos commented 5 years ago

Have to fix this. Either merge this PR or rewrite to work. and push. Just spent hours trying to get this fixed and ended up using @maj0rr repo instead (thank you for saving my life maj0rr)

carderm commented 5 years ago

Have to fix this. Either merge this PR or rewrite to work. and push. Just spent hours trying to get this fixed and ended up using @maj0rr repo instead (thank you for saving my life maj0rr)

Agreed! Given this pull request has no conflicts and is over a year old I've given up on it happening and am just using this branch to add in other useful fixes. :)